Ok figured it out... the tools.iml I was looking at is in a slightly different location (lucene/tools). You shouldn't have one in lucene/analysis/common/src/tools ... and the build overrides the excludes for that area like this:
<!-- some files for testing that do not have license headers --> <property name="rat.excludes" value="**/*.aff,**/*.dic,**/*.txt,**/charfilter/*.htm*,**/*LuceneResourcesWikiPage.html"/> <property name="rat.additional-includes" value="src/tools/**"/>
So iml's are not excluded there, and my original comment that you probably don't want intellij adding a module there does apply.
[rat] AL /Users/dceccarelli4/dev/upstream-lucene-solr/lucene/analysis/common/src/java/org/apache/lucene/analysis/ar/ArabicAnalyzer.java
Intellij probably treated /lucene/analysis/common/src/tools/ as a module and gave it an *.iml file. Not surprisingly the file didn't have a license header. It matches an ignore pattern for git, but RAT is not so easily fooled :)
You possibly want to talk intellij out of treating that directory as a module.
On Thu, Sep 26, 2019 at 8:58 AM Diego Ceccarelli (BLOOMBERG/ LONDON) <[hidden email]> wrote: